fix(task-graph): limit package dependsOn to direct deps#469
Merged
Conversation
Co-authored-by: GPT-5 Codex <codex@openai.com>
wan9chi
force-pushed
the
codex/direct-depends-on-package-selection
branch
from
c9398de to
a1a971a
Compare
Member
Author
wan9chi
added a commit
that referenced
this pull request
Jun 20, 2026
This reverts commit ed454ce. Co-authored-by: GPT-5 Codex <codex@openai.com>
This was referenced Jun 20, 2026
wan9chi
pushed a commit
that referenced
this pull request
Jun 20, 2026
The mechanical reverts of #467 and #469 could not account for changes that landed on main afterwards: - #477 renamed plan task-graph snapshots from `.jsonc` to `.md`, so reverting the `depends_on_package_dependencies` fixture left `snapshots/task_graph.md` behind as an orphan with no package. The plan snapshot harness runs every fixture directory through workspace discovery, so this stale directory would fail the suite — remove it. - `vec1` was used only by the reverted object-form `dependsOn` config, so it is now an unused dependency of `vite_task_graph` that `cargo shear` rejects — drop it. - Reverting #467's `task-query.md` edits would reintroduce the internal `vite-task.json` name into published docs; keep the public `vite.config.*` spelling that main already uses. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QowxsN8vDKKbQdaSMdxL67
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Object-form
dependsOnwas introduced as direct package dependency selection, but the merged implementation also walked through direct dependency packages that did not define the requested task and selected transitive packages. That made{ task, from }broader than the documented direct-dependency feature and could schedule tasks from packages the declaring package did not depend on directly.This PR restores the direct-only behavior: direct dependency packages without the requested task are skipped, while dependency tasks can still declare their own
dependsOnentries for explicit recursive expansion.